cloud-fan commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994627656
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -73,6 +73,21 @@ package object dsl {
relation.setJoin(join).build()
}
+ def sample(
Review Comment:
are all required for the `Sample` query plan, but `df.sample` API has
multiple overloads which provide default values for some parameters. Should the
proto plan match query plan or DF API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
