grundprinzip commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r995079915
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -71,6 +72,15 @@ class SparkConnectPlanner(plan: proto.Relation, session:
SparkSession) {
session.sessionState.sqlParser.parsePlan(sql.getQuery)
}
+ private def transformSample(rel: proto.Sample): LogicalPlan = {
+ Sample(
Review Comment:
Alright, I think this is something that we have to keep in mind when dealing
with the protos. When we want optionality for scalar types we need to wrap them
or properly deal with the zero initialized value.
I think in this case we can probably defer the checking to the analyzer
because it will know if the value combination is invalid.
Maybe it's a good thing that we start some kind of developer docs with these
caveats?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
