grundprinzip commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994776532
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -71,6 +72,15 @@ class SparkConnectPlanner(plan: proto.Relation, session:
SparkSession) {
session.sessionState.sqlParser.parsePlan(sql.getQuery)
}
+ private def transformSample(rel: proto.Sample): LogicalPlan = {
+ Sample(
Review Comment:
Since the proto arguments are not required, this means these values could be
unset, this means that the transform function needs to check if the values are
actually set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
