grundprinzip commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994769825
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -73,6 +73,21 @@ package object dsl {
relation.setJoin(join).build()
}
+ def sample(
Review Comment:
I think we can go with the query plan for now and if we want to introduce
optional behavior it's going to be easy to do because the proto supports
optionality by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
