rmcyang commented on code in PR #39725:
URL: https://github.com/apache/spark/pull/39725#discussion_r1088250874
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1481,6 +1496,9 @@ public void onComplete(String streamId) throws
IOException {
// the client in cases of duplicate even though no data is written.
Review Comment:
The UTs `testBlockPushWithOlderShuffleMergeId` and
`testFinalizeWithOlderShuffleMergeId ` have some stale blocks. Before applying
`updateIgnoredBlockBytes` for `isStale` and `isTooLate` conditions above, they
are not taken account into the ignored bytes. They are able to be captured
after. So I think we should update ignored block bytes there. Updated the PR,
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
