otterc commented on code in PR #39725:
URL: https://github.com/apache/spark/pull/39725#discussion_r1088266355
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1478,13 +1478,15 @@ public void onComplete(String streamId) throws
IOException {
if (isTooLate(info, partitionInfo.reduceId)) {
freeDeferredBufs();
mergeManager.pushMergeMetrics.lateBlockPushes.mark();
+ updateIgnoredBlockBytes();
throw new BlockPushNonFatalFailure(
new BlockPushReturnCode(ReturnCode.TOO_LATE_BLOCK_PUSH.id(),
streamId).toByteBuffer(),
BlockPushNonFatalFailure.getErrorMsg(streamId,
ReturnCode.TOO_LATE_BLOCK_PUSH));
}
if (isStale(info,
partitionInfo.appAttemptShuffleMergeId.shuffleMergeId)) {
freeDeferredBufs();
mergeManager.pushMergeMetrics.staleBlockPushes.mark();
+ updateIgnoredBlockBytes();
Review Comment:
This is not needed. There is an exception thrown in the next line which
triggers `onFailure`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
