mridulm commented on code in PR #39725:
URL: https://github.com/apache/spark/pull/39725#discussion_r1088313746
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1481,6 +1496,9 @@ public void onComplete(String streamId) throws
IOException {
// the client in cases of duplicate even though no data is written.
Review Comment:
> However, when we detect tooLate or tooStale we throw an exception, so
that will trigger onFailure.
I see what you mean, I read it as this wont happen and should have triggered
`onFailure` from `onData` directly.
Agree - since `TransportRequestHandler.processStreamRequest` is explicitly
doing the delegation to `onFailure` when `onComplete` fails, that should be
fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
