otterc commented on code in PR #39725:
URL: https://github.com/apache/spark/pull/39725#discussion_r1088265331
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1481,6 +1496,9 @@ public void onComplete(String streamId) throws
IOException {
// the client in cases of duplicate even though no data is written.
Review Comment:
@mridulm I didn't get your point. I thought you pointed that in `onComplete`
when we detect `tooLate` or `tooStale`, we should update the metric. However,
when we detect `tooLate` or `tooStale` we throw an exception, so that will
trigger `onFailure`.
@rmcyang Can you check if those tests trigger `onFailure` after `onComplete`
throws an exception? If they don't then that's why the metric didn't get
updated. If `onComplete` throws an exception, then `onFailure` should be
invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
