HyukjinKwon commented on code in PR #40722:
URL: https://github.com/apache/spark/pull/40722#discussion_r1161530080
##########
python/pyspark/pandas/data_type_ops/boolean_ops.py:
##########
@@ -241,8 +239,15 @@ def __and__(self, left: IndexOpsLike, right: Any) ->
SeriesOrIndex:
return right.__and__(left)
else:
- def and_func(left: GenericColumn, right: Any) -> GenericColumn:
- if not isinstance(right, GenericColumn.__args__): # type:
ignore[attr-defined]
+ if is_remote():
+ from pyspark.sql.connect.column import Column as ConnectColumn
+
+ Column = ConnectColumn
+ else:
+ Column = PySparkColumn # type: ignore[assignment]
+
+ def and_func(left: Column, right: Any) -> Column: # type:
ignore[valid-type]
+ if not isinstance(right, Column):
Review Comment:
`F.lit(right)` actually returns the column as is. So I believe we can remove
this condition, and if-else above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
