HyukjinKwon commented on code in PR #40722:
URL: https://github.com/apache/spark/pull/40722#discussion_r1161532395
##########
python/pyspark/pandas/data_type_ops/num_ops.py:
##########
@@ -166,7 +205,14 @@ def rmod(self, left: IndexOpsLike, right: Any) ->
SeriesOrIndex:
if not isinstance(right, numbers.Number):
raise TypeError("Modulo can not be applied to given types.")
- def rmod(left: GenericColumn, right: Any) -> GenericColumn:
+ if is_remote():
+ from pyspark.sql.connect.column import Column as ConnectColumn
+
+ Column = ConnectColumn
+ else:
+ Column = PySparkColumn # type: ignore[assignment]
+
+ def rmod(left: Column, right: Any) -> Column: # type:
ignore[valid-type]
Review Comment:
ditto remove
##########
python/pyspark/pandas/data_type_ops/num_ops.py:
##########
@@ -215,18 +281,25 @@ def xor(self, left: IndexOpsLike, right: Any) ->
SeriesOrIndex:
elif _is_valid_for_logical_operator(right):
right_is_boolean = _is_boolean_type(right)
- Column = ConnectColumn if is_remote() else PySparkColumn
+ if is_remote():
+ from pyspark.sql.connect.column import Column as ConnectColumn
+
+ Column = ConnectColumn
+ else:
+ Column = PySparkColumn # type: ignore[assignment]
- def xor_func(left: GenericColumn, right: Any) -> GenericColumn:
+ def xor_func(left: Column, right: Any) -> Column: # type:
ignore[valid-type]
Review Comment:
ditto remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
