HyukjinKwon commented on code in PR #40722:
URL: https://github.com/apache/spark/pull/40722#discussion_r1161530958
##########
python/pyspark/pandas/data_type_ops/boolean_ops.py:
##########
@@ -277,11 +293,18 @@ def __or__(self, left: IndexOpsLike, right: Any) ->
SeriesOrIndex:
return right.__or__(left)
else:
- def or_func(left: GenericColumn, right: Any) -> GenericColumn:
- if not isinstance(right, (Column, ConnectColumn)) and
pd.isna(right):
+ if is_remote():
+ from pyspark.sql.connect.column import Column as ConnectColumn
+
+ Column = ConnectColumn
+ else:
+ Column = PySparkColumn # type: ignore[assignment]
+
+ def or_func(left: Column, right: Any) -> Column: # type:
ignore[valid-type]
+ if not isinstance(right, Column) and pd.isna(right):
Review Comment:
ditto, I believe you can remove `not isinstance(right, Column) and`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
