HyukjinKwon commented on code in PR #40722:
URL: https://github.com/apache/spark/pull/40722#discussion_r1161530190
##########
python/pyspark/pandas/data_type_ops/boolean_ops.py:
##########
@@ -258,14 +263,25 @@ def xor(self, left: IndexOpsLike, right: Any) ->
SeriesOrIndex:
return right ^ left
elif _is_valid_for_logical_operator(right):
- def xor_func(left: GenericColumn, right: Any) -> GenericColumn:
- if not isinstance(right, (Column, ConnectColumn)):
+ if is_remote():
+ from pyspark.sql.connect.column import Column as ConnectColumn
+
+ Column = ConnectColumn
+ else:
+ Column = PySparkColumn # type: ignore[assignment]
+
+ def xor_func(left: Column, right: Any) -> Column: # type:
ignore[valid-type]
+ if not isinstance(right, Column):
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
