rangadi commented on code in PR #41039:
URL: https://github.com/apache/spark/pull/41039#discussion_r1191748881
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -360,7 +360,7 @@ message StreamingQueryManagerCommandResult {
// (Required) The id and runId of this query.
StreamingQueryInstanceId id = 1;
// (Optional) The name of this query.
- string name = 2;
+ optional string name = 2;
Review Comment:
We can also check if the value empty and treat it as missing. Not a fan of
heavy use of optional keyword (Proto3 reluctantly supports it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
