amaliujia commented on code in PR #41039:
URL: https://github.com/apache/spark/pull/41039#discussion_r1192902046
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQuery.scala:
##########
@@ -297,4 +298,20 @@ object RemoteStreamingQuery {
name = if (result.getName.isEmpty) null else result.getName,
sparkSession = sparkSession)
}
+
+ def fromStreamingQueryInstanceResponse(
+ sparkSession: SparkSession,
+ q: StreamingQueryInstance): RemoteStreamingQuery = {
+
+ val name = if (q.hasName) {
+ q.getName
+ } else {
+ null
Review Comment:
Oh because `RemoteStreamingQuery` was not designed to take Option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
