WweiL commented on code in PR #41039:
URL: https://github.com/apache/spark/pull/41039#discussion_r1193425714


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala:
##########
@@ -131,6 +131,7 @@ object CheckConnectJvmClientCompatibility {
       IncludeByName("org.apache.spark.sql.streaming.DataStreamReader.*"),
       IncludeByName("org.apache.spark.sql.streaming.DataStreamWriter.*"),
       IncludeByName("org.apache.spark.sql.streaming.StreamingQuery.*"),
+      IncludeByName("org.apache.spark.sql.streaming.StreamingQueryManager.*"),

Review Comment:
   Too many shouldn't support methods if doing   
`IncludeByName("org.apache.spark.sql.streaming.StreamingQueryManager.*"),`
   :
   ```
   method logName()java.lang.String in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method log()org.slf4j.Logger in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method logInfo(scala.Function0)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method logDebug(scala.Function0)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method logTrace(scala.Function0)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method logWarning(scala.Function0)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method logError(scala.Function0)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method logInfo(scala.Function0,java.lang.Throwable)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method logDebug(scala.Function0,java.lang.Throwable)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method logTrace(scala.Function0,java.lang.Throwable)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method logWarning(scala.Function0,java.lang.Throwable)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method logError(scala.Function0,java.lang.Throwable)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method isTraceEnabled()Boolean in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method initializeLogIfNecessary(Boolean)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method initializeLogIfNecessary(Boolean,Boolean)Boolean in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   synthetic method initializeLogIfNecessary$default$2()Boolean in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method initializeForcefully(Boolean,Boolean)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method 
addListener(org.apache.spark.sql.streaming.StreamingQueryListener)Unit in class 
org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method 
removeListener(org.apache.spark.sql.streaming.StreamingQueryListener)Unit in 
class org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method 
listListeners()Array[org.apache.spark.sql.streaming.StreamingQueryListener] in 
class org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   method 
this(org.apache.spark.sql.SparkSession,org.apache.spark.sql.internal.SQLConf)Unit
 in class org.apache.spark.sql.streaming.StreamingQueryManager does not have a 
correspondent in client version
   Exceptions to binary compatibility can be added in 
'CheckConnectJvmClientCompatibility#checkMiMaCompatibility'
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to