WweiL commented on code in PR #41039:
URL: https://github.com/apache/spark/pull/41039#discussion_r1191749684
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -360,7 +360,7 @@ message StreamingQueryManagerCommandResult {
// (Required) The id and runId of this query.
StreamingQueryInstanceId id = 1;
// (Optional) The name of this query.
- string name = 2;
+ optional string name = 2;
Review Comment:
I see. But then if a user deliberately set the query name to be `""`, it
would be treated as null also. We are fine with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
