viirya commented on code in PR #41614:
URL: https://github.com/apache/spark/pull/41614#discussion_r1238976354
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala:
##########
@@ -364,7 +366,13 @@ case class ShuffledHashJoinExec(
override def doProduce(ctx: CodegenContext): String = {
// Specialize `doProduce` code for full outer join, because full outer
join needs to
// iterate streamed and build side separately.
Review Comment:
We need to update out-of-dated comment.
##########
sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala:
##########
@@ -1436,6 +1442,7 @@ class JoinSuite extends QueryTest with SharedSparkSession
with AdaptiveSparkPlan
}
}
+
Review Comment:
Seems redundant blank link added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
