viirya commented on code in PR #41614:
URL: https://github.com/apache/spark/pull/41614#discussion_r1239017375
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala:
##########
@@ -416,12 +424,15 @@ case class ShuffledHashJoinExec(
|}
""".stripMargin)
+ val isFullOuterJoin = joinType == FullOuter
val joinWithUniqueKey = codegenFullOuterJoinWithUniqueKey(
Review Comment:
These helper method names are tied to full outer join. Maybe it is better to
revise them. Otherwise code readers might be confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
