szehon-ho commented on code in PR #41614:
URL: https://github.com/apache/spark/pull/41614#discussion_r1240571397
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala:
##########
@@ -578,7 +594,9 @@ case class ShuffledHashJoinExec(
|
| if (!$foundMatch) {
| $buildRow = null;
- | $consumeFullOuterJoinRow();
+ | if ($isFullOuterJoin) {
+ | $consumeFullOuterJoinRow();
+ | }
Review Comment:
I end up pulling this in separate if block, leaving to set buildRow=null in
both case if not found match. I was thinking its cleaner, to clear the state,
and more in line with uniqueKey side.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala:
##########
@@ -578,7 +594,9 @@ case class ShuffledHashJoinExec(
|
| if (!$foundMatch) {
| $buildRow = null;
- | $consumeFullOuterJoinRow();
+ | if ($isFullOuterJoin) {
+ | $consumeFullOuterJoinRow();
+ | }
Review Comment:
I end up pulling this in separate if block, leaving to set buildRow=null in
both case if not found match. I was thinking its cleaner, to clear the state,
and more in line with uniqueKey side. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
