szehon-ho commented on code in PR #41614: URL: https://github.com/apache/spark/pull/41614#discussion_r1240569908
########## sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala: ########## @@ -578,7 +594,9 @@ case class ShuffledHashJoinExec( | | if (!$foundMatch) { | $buildRow = null; - | $consumeFullOuterJoinRow(); + | if ($isFullOuterJoin) { + | $consumeFullOuterJoinRow(); + | } Review Comment: I was afraid of side effect if I don't set buildRow to null, if not fullOuterJoin. Let me check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org