hvanhovell commented on code in PR #40997:
URL: https://github.com/apache/spark/pull/40997#discussion_r1244507106
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -252,6 +252,18 @@ class Dataset[T] private[sql] (
}
}
+ private def containsUnboudRowEncoder(enc: AgnosticEncoder[_]): Boolean = {
+ if (enc == UnboundRowEncoder) {
+ true
+ } else {
+ enc match {
+ case ProductEncoder(clsTag, fields) if ProductEncoder.isTuple(clsTag)
=>
Review Comment:
In theory any 'struct' encoder can contain an UnboundRowEncoder. This only
deals with the stuff we can currently create in scala client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
