hvanhovell commented on code in PR #40997:
URL: https://github.com/apache/spark/pull/40997#discussion_r1254947029
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -225,6 +225,16 @@ message Join {
JOIN_TYPE_LEFT_SEMI = 6;
JOIN_TYPE_CROSS = 7;
}
+
+ // (Optional) Only used by joinWith. Set the left and right join data types.
+ optional JoinDataType join_data_type = 6;
+
+ message JoinDataType {
+ // If the left data type is a struct that can be flatten to a row.
+ bool is_left_flattenable_to_row = 1;
Review Comment:
i'd just name this `is_left_struct` or `is_left_single_value`. Flattening is
a detail we don't really care about.
The same applies to the right side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
