hvanhovell commented on code in PR #40997:
URL: https://github.com/apache/spark/pull/40997#discussion_r1244508788
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -224,6 +224,13 @@ message Join {
JOIN_TYPE_LEFT_SEMI = 6;
JOIN_TYPE_CROSS = 7;
}
+
+ // Optional. set to true if the left is a struct that can be flattened to a
row. Only used by
+ // JoinWith where the left is a dataset.
+ optional bool is_left_row_struct = 6;
Review Comment:
Shall we just make this one flag?
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -224,6 +224,13 @@ message Join {
JOIN_TYPE_LEFT_SEMI = 6;
JOIN_TYPE_CROSS = 7;
}
+
+ // Optional. set to true if the left is a struct that can be flattened to a
row. Only used by
+ // JoinWith where the left is a dataset.
+ optional bool is_left_row_struct = 6;
Review Comment:
Can we just make this one flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
