hvanhovell commented on code in PR #40997:
URL: https://github.com/apache/spark/pull/40997#discussion_r1244514591
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/AgnosticEncoder.scala:
##########
@@ -111,14 +111,25 @@ object AgnosticEncoders {
object ProductEncoder {
val cachedCls = new ConcurrentHashMap[Int, Class[_]]
- def tuple(encoders: Seq[AgnosticEncoder[_]]): AgnosticEncoder[_] = {
+ private[sql] def tuple(
Review Comment:
TBH I'd just create a bespoke method for this for joinWith. The current
signature is pretty confusing IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
