beliefer commented on code in PR #42317: URL: https://github.com/apache/spark/pull/42317#discussion_r1356017720
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ########## @@ -29,7 +29,14 @@ import org.apache.spark.sql.internal.SQLConf import org.apache.spark.sql.types._ /** - * Insert a filter on one side of the join if the other side has a selective predicate. + * Insert a runtime filter on one side of the join (we call this side the application side) if + * the plan of other side satisfy one of the following scenes: Review Comment: To be precise, `the other side` may not be `creation side`, the creation side may be a sub plan of the other side. So I adjust this comment. ``` Insert a runtime filter on one side of the join (we call this side the application side) if we can extract a plan (we call this plan the creation side) from the other side and construct a runtime filter with the creation side. A simple case is that the creation side is a table scan with a selective filter. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
