cloud-fan commented on code in PR #42317: URL: https://github.com/apache/spark/pull/42317#discussion_r1356526351
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ########## @@ -29,7 +29,11 @@ import org.apache.spark.sql.internal.SQLConf import org.apache.spark.sql.types._ /** - * Insert a filter on one side of the join if the other side has a selective predicate. + * Insert a runtime filter on one side of the join (we call this side the application side) + * if we can extract a plan (we call this plan the creation side) from the other side and Review Comment: it's weird to call an extracted plan "side". A join has two sides, and we extract a plan from the creation side to build the runtime filter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
