cloud-fan commented on code in PR #42317:
URL: https://github.com/apache/spark/pull/42317#discussion_r1356541828
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -118,17 +122,34 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with
PredicateHelper with J
* filter should be selective and the filter condition (including
expressions in the child
* plan referenced by the filter condition) should be a simple expression,
so that we do
* not add a subquery that might have an expensive computation.
+ *
+ * Note: The parameter `filterCreationSideExp` represents the creation side
expression initially
+ * confirmed outside the extract method. The target creation side expression
may change during
+ * the join relationship pass process. So the extract method returns a
optional tuple,
+ * which contains the target expression and plan of creation side.
Review Comment:
how about
```
Note: The parameter `filterCreationSideExp` represents the creation side
join keys, but the extracted
sub-plan may use different keys as we can extract the sub-plan from both
sides of inner joins and the
join keys can be transitive.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
