cloud-fan commented on code in PR #42317:
URL: https://github.com/apache/spark/pull/42317#discussion_r1356531381
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -118,17 +122,34 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with
PredicateHelper with J
* filter should be selective and the filter condition (including
expressions in the child
* plan referenced by the filter condition) should be a simple expression,
so that we do
* not add a subquery that might have an expensive computation.
+ *
+ * Note: The parameter `filterCreationSideExp` represents the creation side
expression initially
Review Comment:
```suggestion
* Note: The parameter `filterCreationSideExp` represents the creation
side join keys initially
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
