pan3793 commented on code in PR #45851:
URL: https://github.com/apache/spark/pull/45851#discussion_r1549616934
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala:
##########
@@ -1561,9 +1562,9 @@ object CodeGenerator extends Logging {
private def logGeneratedCode(code: CodeAndComment): Unit = {
val maxLines = SQLConf.get.loggingMaxLinesForCodegen
if (Utils.isTesting) {
- logError(s"\n${CodeFormatter.format(code, maxLines)}")
+ logError(log"\n${MDC(FORMATTED_CODE, CodeFormatter.format(code,
maxLines))}")
Review Comment:
IMO this may not be a `LogKey` case.
Typically, `*_ID` stuffs are used as `LogKey` for log aggregating and
filtering, e.g. we may want to collect the whole logs for a task. While for
this case, the generated code is a large string block and mostly non-repeating,
just leave it as the log content is sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
