itholic commented on code in PR #45851:
URL: https://github.com/apache/spark/pull/45851#discussion_r1549651293
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala:
##########
@@ -1561,9 +1562,9 @@ object CodeGenerator extends Logging {
private def logGeneratedCode(code: CodeAndComment): Unit = {
val maxLines = SQLConf.get.loggingMaxLinesForCodegen
if (Utils.isTesting) {
- logError(s"\n${CodeFormatter.format(code, maxLines)}")
+ logError(log"\n${MDC(FORMATTED_CODE, CodeFormatter.format(code,
maxLines))}")
Review Comment:
Thanks for your super fast review @pan3793 @panbingkun !
Then I think we have nothing to do for the SQL catalyst module on migrating
`logError`, but let me wait for the @gengliangwang review as well before
closing :-)
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala:
##########
@@ -1561,9 +1562,9 @@ object CodeGenerator extends Logging {
private def logGeneratedCode(code: CodeAndComment): Unit = {
val maxLines = SQLConf.get.loggingMaxLinesForCodegen
if (Utils.isTesting) {
- logError(s"\n${CodeFormatter.format(code, maxLines)}")
+ logError(log"\n${MDC(FORMATTED_CODE, CodeFormatter.format(code,
maxLines))}")
Review Comment:
Thanks for your super fast review @pan3793 and @panbingkun !
Then I think we have nothing to do for the SQL catalyst module on migrating
`logError`, but let me wait for the @gengliangwang review as well before
closing :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
