panbingkun commented on code in PR #45851:
URL: https://github.com/apache/spark/pull/45851#discussion_r1549642894
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala:
##########
@@ -1561,9 +1562,9 @@ object CodeGenerator extends Logging {
private def logGeneratedCode(code: CodeAndComment): Unit = {
val maxLines = SQLConf.get.loggingMaxLinesForCodegen
if (Utils.isTesting) {
- logError(s"\n${CodeFormatter.format(code, maxLines)}")
+ logError(log"\n${MDC(FORMATTED_CODE, CodeFormatter.format(code,
maxLines))}")
Review Comment:
> Sorry let me just ask some dumb question for my personal understanding.
Then how about this case?
>
>
https://github.com/apache/spark/blob/d487acd3008b6e8e9624295c833a6f87c1102ce9/sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala#L520-L522
>
> Can we use `logKey` maybe something like `FIELD_NAME`??
Yeah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
