panbingkun commented on code in PR #45851:
URL: https://github.com/apache/spark/pull/45851#discussion_r1549640670
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala:
##########
@@ -1561,9 +1562,9 @@ object CodeGenerator extends Logging {
private def logGeneratedCode(code: CodeAndComment): Unit = {
val maxLines = SQLConf.get.loggingMaxLinesForCodegen
if (Utils.isTesting) {
- logError(s"\n${CodeFormatter.format(code, maxLines)}")
+ logError(log"\n${MDC(FORMATTED_CODE, CodeFormatter.format(code,
maxLines))}")
Review Comment:
I think a more appropriate explanation is that if we need to query through
`JSON` in `subsequent` queries, it can be used as a LogKey.
According to the current log4j configuration, it will be output as a `field`
to the `context`, eg:
![Uploading image.png…]()
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala:
##########
@@ -1561,9 +1562,9 @@ object CodeGenerator extends Logging {
private def logGeneratedCode(code: CodeAndComment): Unit = {
val maxLines = SQLConf.get.loggingMaxLinesForCodegen
if (Utils.isTesting) {
- logError(s"\n${CodeFormatter.format(code, maxLines)}")
+ logError(log"\n${MDC(FORMATTED_CODE, CodeFormatter.format(code,
maxLines))}")
Review Comment:
I think a more appropriate explanation is that if we need to query through
`JSON` in `subsequent` queries, it can be used as a LogKey.
According to the current log4j configuration, it will be output as a `field`
to the `context`, eg:
<img width="756" alt="image"
src="https://github.com/apache/spark/assets/15246973/1e5dc4cf-4363-4e2f-b0bf-5beb0e305ca5";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
