uros-db commented on code in PR #46041:
URL: https://github.com/apache/spark/pull/46041#discussion_r1571923683
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##########
@@ -54,7 +54,7 @@ object CollationTypeCasts extends TypeCoercionRule {
case otherExpr @ (
_: In | _: InSubquery | _: CreateArray | _: ArrayJoin | _: Concat | _:
Greatest | _: Least |
- _: Coalesce | _: BinaryExpression | _: ConcatWs) =>
+ _: Coalesce | _: BinaryExpression | _: ConcatWs | _: StringLPad | _:
StringRPad) =>
Review Comment:
we can't just do `collateToSingleType` for all StringLPad/StringRPad
inputTypes, i.e. `Seq(StringTypeAnyCollation, IntegerType,
StringTypeAnyCollation)`
you'll need to add a special case above that only does "collateToSingleType"
for the first and third parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
