uros-db commented on code in PR #46077:
URL: https://github.com/apache/spark/pull/46077#discussion_r1570967566
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##########
@@ -143,7 +145,24 @@ public static boolean execICU(final UTF8String l, final
UTF8String r,
* Collation-aware regexp expressions.
*/
- // TODO: Add more collation-aware regexp expressions.
+ public static boolean supportsLowercaseRegex(final int collationId) {
Review Comment:
there is no behaviour to test in CollationSupportSuite, all collation
awareness here is embedded directly in regexpExpressions instead
this one is gonna have to be a bit different than StringExpressions (in
terms of testing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
