mihailom-db commented on code in PR #46077:
URL: https://github.com/apache/spark/pull/46077#discussion_r1571957856
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##########
@@ -52,6 +52,11 @@ object CollationTypeCasts extends TypeCoercionRule {
overlay.withNewChildren(collateToSingleType(Seq(overlay.input,
overlay.replace))
++ Seq(overlay.pos, overlay.len))
+ case regExpReplace: RegExpReplace =>
+ val singleType = collateToSingleType(Seq(regExpReplace.subject,
regExpReplace.rep))
+ val newChildren = Seq(singleType.head, regExpReplace.regexp,
singleType(1), regExpReplace.pos)
Review Comment:
I find this a bit weird. Could we use `val Seq(first, third) =
collateToSingleType(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
