uros-db commented on code in PR #46077:
URL: https://github.com/apache/spark/pull/46077#discussion_r1570971222
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollationExpressionSuite.scala:
##########
@@ -161,4 +162,40 @@ class CollationExpressionSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvaluation(ArrayExcept(left, right), out)
}
}
+
+ test("MultiLikeBase regexp expressions with collated strings") {
Review Comment:
with StringExpressions, we had a situation where interpreted & codegen
codepaths defaulted to a single function call, so unit tests in
CollationSupportSuite were enough to verify everything goes well there
however here we have to make traditional unit tests in order to verify the
behaviour for both interpreted (nullSafeEval) & codegen (doGenCode) execution
(sql tests don't seem to cover both)
this PR will only be correct once I add unit tests for all other regexp
expressions too, and I figured CollationExpressionSuite is the correct place to
do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
