mihailom-db commented on code in PR #46077:
URL: https://github.com/apache/spark/pull/46077#discussion_r1571964646
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollationExpressionSuite.scala:
##########
@@ -161,4 +162,40 @@ class CollationExpressionSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvaluation(ArrayExcept(left, right), out)
}
}
+
+ test("MultiLikeBase regexp expressions with collated strings") {
Review Comment:
I am a bit sceptical this is the right place for the test. I agree we need
to have it, but does it really belong with CollationExpressions? I would assume
here we only expect tests that check behaviour of Collation and Collate
expressions. Could we maybe move this to CollationRegexpExpressionSuite?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
