grundprinzip commented on code in PR #46789:
URL: https://github.com/apache/spark/pull/46789#discussion_r1640210979
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -54,6 +54,8 @@ message Expression {
google.protobuf.Any extension = 999;
}
+ // (Optional) Keep the information of the origin for this expression such
as stacktrace.
+ Origin origin = 18;
Review Comment:
We already have something similar in `RelationCommon` called `source_info`.
If we do this PR we should mark the ID 1 in RelationCommon as reserved and
remove the value. Then we should add it back as `Origin` with a new ID.
Now, for expressions, I think we should probably create a similar
`ExpressionCommon` message and put it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
