HyukjinKwon commented on code in PR #46789:
URL: https://github.com/apache/spark/pull/46789#discussion_r1641616617
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -405,3 +407,18 @@ message NamedArgumentExpression {
// (Required) The value expression of the named argument.
Expression value = 2;
}
+
+message Origin {
+ // (Required) Indicate the origin type.
+ oneof function {
+ PythonOrigin python_origin = 1;
+ }
+}
+
+message PythonOrigin {
Review Comment:
`StackTraceElement` has JDK dedicated method and fields (e.g.,
`classLoaderName`). I think we should have a dedicated one for individual
languages.
While `DataFrameQueryContext` / `SQLQueryContext` have common information
(for now), I think we will end up with having some language-specific and
dedicated information for both APIs in the future.
However, I am open to having common one. There is a way to have the common
(and, e.g., throw an exception if that information doesn't make sense in some
languages).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
