HeartSaVioR commented on code in PR #47188:
URL: https://github.com/apache/spark/pull/47188#discussion_r1669614627
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/StateTable.scala:
##########
@@ -76,14 +82,31 @@ class StateTable(
override def properties(): util.Map[String, String] = Map.empty[String,
String].asJava
private def isValidSchema(schema: StructType): Boolean = {
Review Comment:
My proposal could handle both non-CDF and CDF altogether and this still
needs a divergence and also every column has its own if or else if. Have you
tried with my proposal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
