eason-yuchen-liu commented on code in PR #47188:
URL: https://github.com/apache/spark/pull/47188#discussion_r1670938847
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -469,6 +469,15 @@ trait SupportsFineGrainedReplay {
def replayReadStateFromSnapshot(snapshotVersion: Long, endVersion: Long):
ReadStateStore = {
new WrappedReadStateStore(replayStateFromSnapshot(snapshotVersion,
endVersion))
}
+
+ /**
+ *
+ * @param startVersion
+ * @param endVersion
+ * @return
+ */
+ def getStateStoreChangeDataReader(startVersion: Long, endVersion: Long):
Review Comment:
I see your point now. I would say to make the interface easier for users to
implement, why don't we use the superclass of `StateStoreChangeDataReader`
which is `NextIterator` as the interface. It has two well defined extendible
method `getNext` and `close` and it is also stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
