HeartSaVioR commented on code in PR #47188:
URL: https://github.com/apache/spark/pull/47188#discussion_r1671393537
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/StateDataSource.scala:
##########
@@ -262,7 +262,7 @@ object StateSourceOptions extends DataSourceOptions {
if (changeStartBatchId.isEmpty) {
throw
StateDataSourceErrors.requiredOptionUnspecified(CHANGE_START_BATCH_ID)
}
- changeEndBatchId = Option(
+ changeEndBatchId = Some(
Review Comment:
The change from Option to Some to pass the test concerns me. The difference
only happens when we could get null value, and if we perform get in Some(null)
this would be problematic anyway.
@eason-yuchen-liu Could you please explain the rationale of the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
