eason-yuchen-liu commented on code in PR #47188:
URL: https://github.com/apache/spark/pull/47188#discussion_r1671032692
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreChangelog.scala:
##########
@@ -260,7 +270,7 @@ abstract class StateStoreChangelogReader(
}
protected val input: DataInputStream = decompressStream(sourceStream)
- def close(): Unit = { if (input != null) input.close() }
+ override protected def close(): Unit = { if (input != null) input.close() }
Review Comment:
This change is to make sure `StateStoreChangelogReader` correctly implements
the interface of `NextIterator`, method `closeIfNeeded` should be used instead
of `close`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
