GideonPotok commented on PR #47154: URL: https://github.com/apache/spark/pull/47154#issuecomment-2265373898
> left some comments, code structure looks much better than before in my opinion > > let's just clean this up a bit - not leave behind any comments from prototyping tests, and be a bit more careful with the naming overall > > also, will we add support for MapType? Re MapType: I think we shouldn't. I don't have as much capacity right now, so i prefer to keep it simple. Does that sound okay? I will let you know once all the suggested cleanup is in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
