GideonPotok commented on code in PR #47154:
URL: https://github.com/apache/spark/pull/47154#discussion_r1709916700
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##########
@@ -103,16 +156,8 @@ case class Mode(
*
* The new map is then used in the rest of the Mode evaluation logic.
*/
- val collationAwareBuffer = child.dataType match {
- case c: StringType if
- !CollationFactory.fetchCollation(c.collationId).supportsBinaryEquality
=>
- val collationId = c.collationId
- val modeMap = buffer.toSeq.groupMapReduce {
- case (k, _) =>
CollationFactory.getCollationKey(k.asInstanceOf[UTF8String], collationId)
- }(x => x)((x, y) => (x._1, x._2 + y._2)).values
- modeMap
- case _ => buffer
- }
+ val collationAwareBuffer = getCollationAwareBuffer(child.dataType, buffer)
Review Comment:
Done. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
