uros-db commented on code in PR #47154:
URL: https://github.com/apache/spark/pull/47154#discussion_r1711105054
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##########
@@ -42,28 +42,30 @@ case class Mode(
this(child, 0, 0, Some(reverse))
}
- // Returns null for empty inputs
- override def nullable: Boolean = true
-
- override def dataType: DataType = child.dataType
-
- override def inputTypes: Seq[AbstractDataType] = Seq(AnyDataType)
-
override def checkInputDataTypes(): TypeCheckResult = {
- if (UnsafeRowUtils.isBinaryStable(child.dataType) ||
child.dataType.isInstanceOf[StringType]) {
+ if (UnsafeRowUtils.isBinaryStable(child.dataType) ||
+ !child.dataType.existsRecursively(f => f.isInstanceOf[MapType] &&
+ !UnsafeRowUtils.isBinaryStable(f))) {
/*
* The Mode class uses collation awareness logic to handle string data.
* Complex types with collated fields are not yet supported.
*/
// TODO: SPARK-48700: Mode expression for complex types (all collations)
super.checkInputDataTypes()
} else {
- TypeCheckResult.TypeCheckFailure("The input to the function 'mode' was" +
- " a type of binary-unstable type that is " +
- s"not currently supported by ${prettyName}.")
+ TypeCheckResult.TypeCheckFailure("The input to the function 'mode'
includes" +
+ " a map with keys and/or values which are not binary-stable. This is
not yet" +
+ s"supported by ${prettyName}.")
Review Comment:
of course, we can do MapType as a follow-up - let's just make sure to put a
comment for this somewhere tho
and an appropriate test to catch this for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
