stefankandic commented on code in PR #48222:
URL: https://github.com/apache/spark/pull/48222#discussion_r1773685139
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala:
##########
@@ -640,6 +639,26 @@ case class QualifyLocationWithWarehouse(catalog:
SessionCatalog) extends Rule[Lo
}
}
+object TrimCollationCheck extends (LogicalPlan => Unit) {
Review Comment:
Analyzer is pretty slow right now, it runs the rules iteratively over and
over again until the plan gets to the fixed point - which can be very slow for
bigger queries. That's why I try to avoid introducing anything new that could
increase that complexity further.
Btw, my analyzer knowledge is also very shallow, maybe @vladimirg-db can
provide an expert opinion here 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
