jovanpavl-db commented on code in PR #48222:
URL: https://github.com/apache/spark/pull/48222#discussion_r1774996157
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -200,6 +201,7 @@ public Collation(
* bit 28-24: Reserved.
* bit 23-22: Reserved for version.
* bit 21-18: Reserved for space trimming.
+ * 0000 = none, 0001 = left trim, 0010 = right trim, 0011 = trim.
Review Comment:
Can you provide some use-case where this one bit would be useful? IMO let's
leave one bit reserved, maybe for different class of trimmings (for example not
just ascii 20).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
