uros-db commented on code in PR #48222:
URL: https://github.com/apache/spark/pull/48222#discussion_r1774931595
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -200,6 +201,7 @@ public Collation(
* bit 28-24: Reserved.
* bit 23-22: Reserved for version.
* bit 21-18: Reserved for space trimming.
+ * 0000 = none, 0001 = left trim, 0010 = right trim, 0011 = trim.
Review Comment:
here's a thought: should we consider having one bit signaling whether there
is any trimming sensitivity or not? for example, case and accent sensitivity
have a 1-bit signal (albeit, those speficiers are of binary value)
while I would agree that it's not immediately useful, but this "feature" in
the collationId schema might come in handy in the future. thoughts? cc
@nikolamand-db @stefankandic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
