stefankandic commented on code in PR #48737:
URL: https://github.com/apache/spark/pull/48737#discussion_r1831542148
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -83,9 +83,18 @@ class StringType private (val collationId: Int) extends
AtomicType with Serializ
override def jsonValue: JValue = JString("string")
override def equals(obj: Any): Boolean =
Review Comment:
@cloud-fan But this is a user facing change, wouldn't it be counterintuitive
if `StringType == StringType("UTF8_BINARY")` returned false, implying that
default collation is not utf8 binary? @srielau do you have any opinions here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
